dangernoodle-io / breadboard / 30058864709

96%

push

github

refactor: make bb_serialize meta engine + tables device-shippable (gated off) (#1036)

- relocate host_tools/bb_serialize_meta/ into a real components/bb_serialize_meta/
  ESP-IDF component (include/ + src/), so the engine + co-located
  bb_serialize_desc_meta_t tables can compile into firmware instead of being
  structurally unreachable from any device build
- add BB_SERIALIZE_META_SHIP gate (BB_SERIALIZE_META_HOST OR
  CONFIG_BB_OPENAPI_RUNTIME_META) in bb_serialize_meta.h; mechanically swap
  every co-located meta table's guard from BB_SERIALIZE_META_HOST to
  BB_SERIALIZE_META_SHIP
- add CONFIG_BB_OPENAPI_RUNTIME_META (components/bb_openapi/Kconfig, default n)
  and gate the new component's SRCS on it, so the default build ships zero
  bytes of this code
- fix two latent include-order bugs found by real-device compile testing:
  bb_system_routes.c/bb_storage_http_routes.c relied on a nested *_TESTING
  guard to pull in bb_serialize_meta.h, which never fires on a real device
  build; and every consumer's guard-then-include pattern read
  BB_SERIALIZE_META_SHIP before it could ever be defined (it's set INSIDE
  bb_serialize_meta.h) -- moved every #include "bb_serialize_meta.h" to be
  unconditional, ahead of its own guard
- add bb_serialize_meta to PRIV_REQUIRES for every consumer component; drop
  the now-redundant host_tools/bb_serialize_meta coverage FILTERS entries
  (already covered by the components/ filter) and PlatformIO lib_extra_dirs
  hack (superseded by the real component graph)
- approve the new_component fence baseline entry

Verified: 4849+2 host tests green; bb_serialize_meta engine at 100% line
coverage; make check clean; floor/esp32 smoke builds byte-identical with
CONFIG_BB_OPENAPI_RUNTIME_META off (.text matches origin/main exactly, zero
bb_serialize_meta objects), and forced on (compiles cleanly, but the new
code is entirely --gc-sections-stripped since nothing calls it yet --
confirmed via nm: zero bb_serialize_meta symbols in ... (continued)

7532 of 8129 branches covered (92.66%)

Branch coverage included in aggregate %.

12799 of 12961 relevant lines covered (98.75%)

2506.42 hits per line