dangernoodle-io / breadboard / 30053550995

97%

push

github

refactor: drive /api/diag/sockets via bb_serialize descriptor (#1034)

Migrates GET /api/diag/sockets from hand-streamed cJSON to a bb_serialize
descriptor (bb_diag_sockets_get_wire_desc), following the panic/partitions
diag-conversion pattern (B1-1054 stream, B1-1059 meta-derivation feeder).

- by_state changes from an untyped additionalProperties object to 11
  individually-named required integer fields (CLOSED..TIME_WAIT); the
  runtime handler already emitted all 11 unconditionally, so this is a
  schema tightening only -- runtime JSON is byte-identical. The hand
  s_sockets_get_responses[] literal is updated to match.
- pcbs[] row cap (BB_DIAG_SOCKETS_ROW_CAP) tracks CONFIG_LWIP_MAX_SOCKETS
  via a Kconfig bridge instead of a hand constant, so a raised socket
  budget (B1-745) can never silently truncate the array.
- The wire snapshot and its PCB staging buffer are heap-allocated
  (bb_malloc_prefer_spiram), not stack locals -- the row cap can grow
  large enough to blow a task stack on a no-PSRAM target.


Claude-Session: https://claude.ai/code/session_01UwuRBPS8n5TkVkog1RQyVF

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

7520 of 8117 branches covered (92.65%)

Branch coverage included in aggregate %.

29 of 29 new or added lines in 1 file covered. (100.0%)

12752 of 12914 relevant lines covered (98.75%)

2500.88 hits per line