carlobeltrame / ecamp3 / 30044788754

34%

devel: 43%

push

github

Fix client print aborting while writing the pdf blob

With the recent react-pdf update, pdf generation has sometimes stopped
randomly just before being finished.
At the same time, the client print e2e test has become flaky when
updating react-pdf.
The reason is that the events sent by pdfkit while streaming the
finalized pdf just abort at some (deterministic) point, and the pdf is
never finished.
After many experiments, the following measures have brought some
improvements:
- Disable pdf compression -> the final streaming is then synchronous
  -> this has been enough to fix the problem outside of CI
- Replace the setTimeout queue polyfill with queueMicrotask using a patch
  -> This is polyfilled because react-pdf uses node-specific code internally
- Lessen the CPU load in CI by reducing the DB_CPU_LIMIT from 4 to 2
  -> This has more or less fixed the problem on CI, but is not a feature fix
- Extra deflaking using retries: 2 on this e2e test

671 of 4519 branches covered (14.85%)

Branch coverage included in aggregate %.

4444 of 10698 relevant lines covered (41.54%)

63.65 hits per line