dangernoodle-io / breadboard / 30022154301

96%

push

github

feat: add oneOf meta support + co-locate meta for reboot/storage-delete request descriptors (#1023)

extends the bb_serialize meta/openapi engine (host_tools/bb_serialize_meta) with
a bb_serialize_meta_kind_t (FIELD/ONEOF) plus per-row occurrence/branches so a
duplicate-`.key` field group can be documented either as a JSON Schema "oneOf"
(all physical occurrences are real, user-facing shapes) or as a single
occurrence-tagged row (only one occurrence is ever meant to surface, the rest
stay doc-invisible) -- bb_serialize_meta_openapi.c's top-level field/required
loops become occurrence-aware and gain bb_oa_write_oneof(), and
bb_serialize_meta_validate.c relaxes its per-field bijection to a per-key one,
opt-in per duplicate key (an unannotated duplicate key still fails).

co-locates host meta tables for the 2 remaining duplicate-key REQUEST
descriptors: POST /api/reboot's s_reboot_desc ("ts" bound U64+F64 -- NOT a
oneOf, the F64 is an internal divergence-guard shadow never meant to surface,
so the meta table documents only the U64 occurrence) and DELETE
/api/diag/storage's s_storage_delete_desc ("namespace" bound STR+ARR-of-STR --
a genuine oneOf, both occurrences are real request shapes). Byte-equal golden
tests against each hand-authored request_schema literal, plus engine-level
synthetic Unity coverage (clean oneOf, reboot-shaped occurrence tag,
branch-count mismatch, occurrence-out-of-range, orphan branch, missing
branches, null branch entry, unannotated-duplicate-rejected) driving both
touched engine files to 100%/100% line+branch coverage. zero device bytes
(BB_SERIALIZE_META_HOST is host-only, verified byte-identical per-object
against the pre-change baseline), zero production behavior change.

refs B1-1181a

7444 of 8038 branches covered (92.61%)

Branch coverage included in aggregate %.

74 of 74 new or added lines in 2 files covered. (100.0%)

12624 of 12786 relevant lines covered (98.73%)

2492.54 hits per line