rollandf / sriov-network-operator / 30008026258

63%

master: 64%

push

github

mellanox: soft-skip DDI when firmware rejects HCA capability change

doca_mgmt_data_direct can exit 1 with DOCA_ERROR_IO_FAILED when the NIC
has an fwctl device but the firmware does not support the DDI capability
at the current firmware version or configuration (syndrome 0xc430).

This was causing the entire PF configuration to abort and the
SriovNetworkNodeState to never reach Synced.

Add three new soft-skip strings to ddiResult():
  - "Failed to set data direct"    (top-level binary error)
  - "DOCA_ERROR_IO_FAILED"         (DOCA error code)
  - "Failed to set HCA capabilities" (firmware command rejection)

These are permanent firmware capability mismatches, not transient
errors, so VF configuration continues without DDI rather than failing.

Also add a table-driven unit test for ddiResult() covering all
soft-skip paths including the new firmware-rejection cases.

Signed-off-by: Fred Rolland <frolland@nvidia.com>

7 of 7 new or added lines in 1 file covered. (100.0%)

10622 of 16858 relevant lines covered (63.01%)

0.7 hits per line