rollandf / sriov-network-operator

63%

master: 63%

LAST BUILD ON BRANCH fix/ut-failures

branch: SELECT

CHANGE BRANCH

x

Sync Branches

• No branch selected
• CVE-2021-20206
• CVE-2022-1996
• CVE-2022-3064
• add-u
• add-u-br
• align-docker
• baseimage
• baseimage25.10
• bp-goproxy
• bridgesecure
• busybox
• check-dra
• ci-base-branch
• ci-pr-branch
• ci-pr-branch-back
• ci-pr-title
• daemonresult
• delete
• dependabot/docker/golang-1.25
• dependabot/docker/golang-1.26
• dependabot/github_actions/actions/checkout-5
• dependabot/github_actions/actions/checkout-6
• dependabot/github_actions/actions/labeler-6
• dependabot/github_actions/actions/setup-go-6
• dependabot/github_actions/actions/upload-artifact-5
• dependabot/github_actions/azure/setup-helm-4.3.1
• dependabot/github_actions/coverallsapp/github-action-2.3.6
• dependabot/github_actions/coverallsapp/github-action-2.3.7
• dependabot/github_actions/docker/build-push-action-6
• dependabot/github_actions/docker/setup-buildx-action-3
• dependabot/github_actions/github/codeql-action-4
• dependabot/go_modules/general-dependencies-070606913e
• dependabot/go_modules/general-dependencies-35e5ba6828
• dependabot/go_modules/general-dependencies-5b87cf7aa9
• dependabot/go_modules/general-dependencies-8e0f654415
• dependabot/go_modules/golang.org/x/crypto-0.45.0
• disable-plugins-helm
• docker-again
• dockerarg
• dockerargbp
• dockerbp
• dra-design
• dra-poc
• empty-dir-ups
• events
• fix/ut-failures
• force
• force-backport
• gitignore
• gitignoremaster
• goconst
• goproxy
• gov-ready
• gpg
• grpc-cve
• hook-affinity
• ignition-cve
• karg-temp
• karg-temp-restore
• labeler
• log-name
• loop
• loop-restore
• master
• mtu-ovs
• nvstaging
• oauth
• oauth2
• oauth3
• otherconfigbp261
• ovs-internal
• remove-license-check
• revert-grub
• securebridgeovs
• typo
• updates-26.1.x
• webhookport

Build # 25053531349

Build Type

push

github

Committed by rollandf

Commit Message

fix: restore broken test code introduced by bad merge conflict resolutions

Four bugs were introduced in sriovoperatorconfig_controller_test.go
during upstream syncs:

1. Two Delete() calls had their ObjectMeta stripped
   (`&SriovOperatorConfig{}` with no name/namespace), causing
   "resource name may not be empty" → the SriovOperatorConfig/default
   was never cleaned up, which cascaded into the sriovnetworknodepolicy
   controller suite's BeforeAll failing with "already exists" (409).

2. assertResourceExists() for the ServiceMonitor was called with an
   empty GroupVersionKind{} instead of the real monitoring.coreos.com/v1
   ServiceMonitor GVK.

3. A duplicate bare Expect(err) was left alongside the g.Expect(err)
   inside an Eventually closure, causing potential double-failure
   reporting.

Signed-off-by: Fred Rolland <frolland@nvidia.com>
Made-with: Cursor

Coverage Stats

10059 of 16062 relevant lines covered (62.63%)

0.7 hits per line