moonbitlang / core / 5498
91%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 435
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 91.271%. Remained the same
5498

push

github

bobzhang 
feat(json): make trait promotions explicit via extend

Enable `implicit_impl_as_method` (E0079) for the `json` package and make its
trait-impl promotions explicit, in a dedicated json/extends.mbt shim (plus inline
`extend`s in the test files that define test-only types).

- Promote (plain `pub extend`): `Show::{to_string}` for `JsonPath`,
  `JsonDecodeError`, `ParseError` (display/error types).
- Deprecate (`#deprecated(..., skip_current_package=true)` + `#doc(hidden)`):
  * `Json`: `FromJson`, `ToJson`, `Show::{to_string, output}` (Json's Show is
    already `#deprecated` on main -> deprecate fully).
  * `JsonPath` / `JsonDecodeError` / `ParseError`: `@debug.Debug::{to_repr}`, `Eq`,
    `Show::{output}`, `ToJson::{to_json}` (`to_string` promoted).
  * `Position`: `@debug.Debug`, `Eq`, `ToJson`.  `Replacer`: `@debug.Debug`.
- 10 blackbox-test / doc types (AllThree, Color, DecodeError, Expr, Hello, Hello3,
  Line, NestedJsonValue, Opt, P) get inline `pub extend` promotions in their files.

Deprecating `Json`/`JsonPath`/... `to_json` + `from_json` has ZERO cross-package
ripple: downstream uses the free `@json.to_json` / `@json.from_json` (and the
traits), not `x.to_json()` method syntax, and internal calls are covered by
`skip_current_package`.

Part of the per-package series (see #3849 for deque). Scoped to json/.

Verified: `moon check --deny-warn --target all` clean; `moon test -p json --target all` green (185 tests).

Reviewed by Codex CLI: E0079 cleared; error/path to_string promoted, to_json/from_json/Eq/Debug/Show-output
deprecated+hidden; test types promoted inline; zero cross-package ripple; scoped to json/.

Signed-off-by: Codex CLI <codex@openai.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

15883 of 17402 relevant lines covered (91.27%)

189058.91 hits per line

Jobs
ID Job ID Ran Files Coverage
1 5498.1 436
91.29
 GitHub Action Run
Source Files on build 5498