moonbitlang / core / 5488
91%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 434
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 91.271% (-0.006%) from 91.277%
5488

push

github

bobzhang 
feat(error): make trait promotions explicit via extend

Enable `implicit_impl_as_method` (E0079) for the `error` package and make its
trait-impl promotions explicit, in a dedicated error/extends.mbt shim (plus
inline `extend`s in the test/README files that define test-only suberrors).

- `Error::to_string` / `Error::to_json`: these already have private `%error.*`
  FFI methods of the same name, so promoting `Show::to_string` / `ToJson::to_json`
  via `extend` collides (E4056). Per the compiler's alternative remedy, the FFI
  methods are made `pub` (with doc comments) so they ARE the explicit regular
  methods -- no `extend` needed, and E0079 is satisfied. pkg.generated.mbti gains
  exactly these two (previously implicitly-promoted) signatures.
- Deprecate (`#deprecated(..., skip_current_package=true)` + `#doc(hidden)`):
  `Error`'s `Show::output` (the value/display split keeps `to_string`, deprecates
  `output`).
- Test/README suberrors that `derive(ToJson)` (ErrWithToJson in error_test.mbt,
  MyError in README.mbt.md) get inline `pub extend ... ToJson::{to_json}`.

No cross-package deprecation ripple (`moon check --deny-warn --target all` clean).
Part of the per-package series (see #3849 for deque). Scoped to error/.

Verified: `moon check --deny-warn --target all` clean; `moon test -p error
--target all` green (13 tests).

Reviewed by Codex CLI: E0079 cleared; Error to_string/to_json FFI made pub (explicit
methods, no colliding extend); Show::output deprecated+hidden; test/README suberrors
promoted inline; .mbti +2/-0; scoped to error/.

Signed-off-by: Codex CLI <codex@openai.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

15883 of 17402 relevant lines covered (91.27%)

189058.79 hits per line

Coverage Regressions

Lines Coverage ∆ File
1
50.0
 -50.0% error/error.mbt
Jobs
ID Job ID Ran Files Coverage
1 5488.1 435
91.29
 GitHub Action Run
Source Files on build 5488