DrRataplan / xq-lsp / 29937279937

93%

Build Type

push

github

Committed by DrRataplan

Commit Message

fix: infer arithmetic types and stop misinferring literal path exprs as nodes

Two real bugs found via inlay hints showing wrong/missing info:

- inferExprType had no case for AdditiveExpr/MultiplicativeExpr at all,
  so any arithmetic (+, -, *, div, idiv, mod) inferred as unknown —
  e.g. "let $y := 23 div 24" showed no hint whatsoever. Added arithmetic
  result inference reusing the existing isAtomicSubtype/xs:numeric
  promotion chain rather than a new hardcoded numeric ordering: normal
  numeric widening for +/-/*';  mod, plus the two special cases per
  XPath F&O (integer div integer always yields xs:decimal; idiv always
  yields xs:integer).

- The PathExpr/RelativePathExpr case assumed any expression containing
  a bare "/" was node-producing, purely from the presence of the
  operator terminal. Since XQuery's grammar allows any PrimaryExpr
  (including plain literals) as a path step, "23 / 2" parses as a
  syntactically valid two-step path and was inferred as node()* — a
  case checkTypes would have surfaced as a bogus type error had that
  path been passed to a node()-typed parameter. Now checks every step
  via inferExprType itself and only assumes node()* when no step is
  provably a non-node type.

Coverage Stats

1402 of 1664 branches covered (84.25%)

Branch coverage included in aggregate %.

55 of 56 new or added lines in 1 file covered. (98.21%)

1 existing line in 1 file now uncovered.

5169 of 5422 relevant lines covered (95.33%)

334339.93 hits per line