source-academy / frontend / 29904561298

42%

push

github

fix: encode Python language selection in share links (#4152)

* fix: encode Python language selection in share links

Share links previously only encoded the js-slang Chapter/Variant,
so a Conductor-based language selection (e.g. Python) was dropped
when sharing and on decode. Add a `lang` query param carrying
languageDirectory.selectedLanguageId, and restore it via
LanguageDirectoryActions.setSelectedLanguage on load.

Fixes #4144

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* fix: restore the selected evaluator when opening a Python share link

Restoring a share link for a Conductor language only reselected the
language (e.g. Python) and not the evaluator (e.g. PVML vs CSE), since
setSelectedLanguage's evaluatorId payload was accepted but ignored by
both the reducer and the saga's evaluator-defaulting logic. The
default-first-evaluator behavior now only kicks in when no valid
evaluatorId is supplied.

Share links now also encode selectedEvaluatorId (as `evaluator`) and
decode/pass it through setSelectedLanguage so reopening a shared link
restores the exact evaluator, not just the language.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* fix: restore missing trailing comma flagged by format:ci

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

2745 of 7553 branches covered (36.34%)

Branch coverage included in aggregate %.

6 of 11 new or added lines in 4 files covered. (54.55%)

6455 of 14201 relevant lines covered (45.45%)

28.44 hits per line