moonbitlang / core / 5302
91%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 396
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 91.293%. Remained the same
5302

push

github

bobzhang 
feat(queue): make trait promotions explicit via extend

Enable `implicit_impl_as_method` (E0079) for the `queue` package (in its
moon.pkg) and make its trait-impl promotions explicit via `extend`, in a
dedicated `queue/extends.mbt` shim.

Queue has no methods worth keeping promoted: the compiler flags only Show and
@quickcheck.Arbitrary, both of which we deprecate:
- `Show::{to_string, output}` -- Queue is a collection, so like Rust (Debug, not
  Display) its Show is deprecated in favour of @debug.Debug (Queue's Show impl is
  already #deprecated on main). The message mirrors that existing impl-level
  deprecation (rationale + link).
- `@quickcheck.Arbitrary::{arbitrary}` -- deprecated in favour of
  `@quickcheck.Arbitrary::arbitrary`.

Deprecation messages name the concrete replacement to call (addressing the
Copilot review). Both extends carry `#deprecated(..., skip_current_package=true)`
+ `#doc(hidden)`, so they stay callable (with a deprecation warning) but are
absent from pkg.generated.mbti -- the generated interface is unchanged. (Queue's
Eq impl is not promoted anywhere, so it needs no extend.)

Part of the per-package series migrating the library off implicit method
promotion (see #3849 for deque). Scoped to `queue`.

Verified: `moon check --deny-warn --target all` clean; `moon test --target all`
green.

Reviewed by Codex CLI: both improved #deprecated message strings are well-formed,
extends coverage/scoping unchanged (Arbitrary + Show, deprecated + hidden), and
the .mbti is byte-identical to main.

Signed-off-by: Codex CLI <codex@openai.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

15885 of 17400 relevant lines covered (91.29%)

189078.42 hits per line

Jobs
ID Job ID Ran Files Coverage
1 5302.1 397
91.31
 GitHub Action Run
Source Files on build 5302