blevesearch / bleve / 29896019522

52%

Build Type

push

github

Committed by web-flow

Commit Message

MB-72489: standalone query hot-path optimizations (#2381)

Five standalone performance optimizations on query hot paths, each
independently benchmarked (Apple M4 Pro, benchstat). No functional/API
changes.

### Changes

- **Fast-path `prepareDocumentMatch` + guard `adjustDocumentMatch` for
non-KNN queries** — skip KNN adjustment and the always-false prepare
branches on simple score-sorted queries. `Top{K}of{N}Scores` geomean
**-1.8%**.
- **Close orphaned sub-searchers after unadorned disjunction
optimization** *(correctness fix)* — `newDisjunctionSearcher` never
closed the original N sub-searchers after the `disjunction:unadorned`
optimization, so their TermFieldReaders were never released and
search-accounting was skipped. Now closed immediately after the
optimization succeeds.
- **Skip empty-bitmap work in `disjunction:unadorned` `Finish()`** —
remove a dead O(segments × terms) loop and reuse empty/1-hit iterator
singletons instead of allocating. Also lets the empty sentinel compose
in nested disjunction/conjunction optimizations.
- **Specialized score-descending comparator for the top-N collector** —
detect the common single-score-descending sort at construction time and
compare `Score` directly instead of walking the generic sort-order path.
Collector geomean **-11.6%** for score-sorted queries.
- **`MergeFieldTermLocations` fast-path + `DocumentMatch.Reset`
nil-guard** — early-return when no match carries field-term locations
(**-49%**), and skip `clear()` on a nil score breakdown (**-13%**). Both
run per scored candidate.

Benchmarks for each change are included in the diff. Marked draft
pending review.

---------

Co-authored-by: Steve Yen <steve.yen@gmail.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Thejas-bhat <thejas.orkombu@couchbase.com>

Coverage Stats

52 of 131 new or added lines in 8 files covered. (39.69%)

4 existing lines in 1 file now uncovered.

19862 of 37974 relevant lines covered (52.3%)

0.59 hits per line