grobidOrg / grobid / 29894596492

44%

push

github

Fix evaluation script on invalid arguments instead of exiting 0 (#1515)

EndToEndEvaluation.main() validated its arguments and then returned, so
the JVM exited 0. Gradle reported BUILD SUCCESSFUL, run_evaluation.sh
saw a successful build, and the only symptom was the missing markdown
report - reported as "report not found after successful build", which
points at the report rather than at the argument that was rejected.

Reproduced with `-PfileRatio=article/light-ref`: "Invalid argument
fileRatio, must be a double" on stderr, BUILD SUCCESSFUL, exit 0.

Every validation bail-out in main() now exits 1, so the failure surfaces
where it happens.

Two related traps, same shape:

- An unrecognised flavor fell back to the default process with only an
  informational message, so the evaluation silently measured something
  other than what was asked for and the report gave no hint. A non-empty
  flavor that does not resolve is now an error listing the known
  flavors. An absent or empty flavor still means the default.

- run_evaluation.sh's -f is the file ratio; the flavor is -l. Passing a
  flavor to -f was accepted and only failed much later. -f is now
  validated, and a value containing '/' suggests -l instead.

Signed-off-by: Luca Foppiano <luca@foppiano.org>

---------

Signed-off-by: Luca Foppiano <luca@foppiano.org>

10125 of 25680 branches covered (39.43%)

Branch coverage included in aggregate %.

21218 of 46354 relevant lines covered (45.77%)

1.86 hits per line