NVIDIA / nodewright / 29869375647
79%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 59
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 78.836% (-3.5%) from 82.371%
29869375647

push

github

web-flow 
feat: rename the Skyhook API to NodeWright with a rollback-safe migration bridge (#349)

* feat(api): add nodewright.nvidia.com group + Skyhook->NodeWright migration base

Introduce the nodewright.nvidia.com/v1alpha1 API group (NodeWright,
DeploymentPolicy) as a fork of the legacy skyhook.nvidia.com types, plus the
operator-side migration scaffolding:

- typed field-by-field conversion (api/v1alpha1/nodewright_conversion.go) with
  exhaustive fidelity + reflection-based zero-value-guard tests
- new-group validating/mutating webhooks
- a level-triggered mirror controller importing legacy Skyhook/DeploymentPolicy
  objects into the new group (read-only on source, ownership-stamped, never
  deletes the target)
- deprecation warnings on legacy Skyhook/DeploymentPolicy writes
- migration guide (docs/nodewright-migration.md)

Shared base for the rename. Reconciler repoint, CLI, chart sync, and the
nodewright type generator (re-fork automation) follow as separate changes.

Signed-off-by: Brian Lockwood <lockwobr@gmail.com>

* fix(ci): satisfy golangci-lint and markdownlint

- use reflect.Pointer instead of the deprecated reflect.Ptr in the conversion
  zero-value guard (govet inline check)
- fix markdownlint in docs/nodewright-migration.md: merge adjacent blockquotes
  (MD028) and repoint the dead #timing anchor to the renamed prerequisite
  section (MD051)

Signed-off-by: Brian Lockwood <lockwobr@gmail.com>

* fix(config): install nodewright CRDs and grant nodewright RBAC

The mirror controller creates nodewright.nvidia.com objects, so the operator
needs the new-group CRDs installed and RBAC to write them. Add the two
nodewright CRDs to config/crd/kustomization.yaml and kubebuilder:rbac markers
on the mirror reconciler (regenerating config/rbac/role.yaml). Without this a
deployed operator's mirror is denied / hits a missing CRD.

Signed-off-by: Brian Lockwood <lockwobr@gmail.com>

* chore(api): generate nodewright group from legacy (kill copy drift)

Add sc... (continued)

2281 of 2797 new or added lines in 42 files covered. (81.55%)

438 existing lines in 6 files now uncovered.

10013 of 12701 relevant lines covered (78.84%)

7.97 hits per line

Uncovered Changes

Lines Coverage ∆ File
196
67.92
 operator/api/nodewright/v1alpha1/zz_generated.deepcopy.go
46
80.0
 operator/api/nodewright/v1alpha1/deployment_policy_types.go
46
86.89
 operator/api/nodewright/v1alpha1/nodewright_types.go
37
83.96
 -0.43% operator/internal/controller/skyhook_controller.go
34
84.47
 operator/api/nodewright/v1alpha1/nodewright_webhook.go
27
80.29
 operator/internal/controller/mirror_controller.go
26
93.7
 operator/api/v1alpha1/nodewright_conversion.go
14
46.95
 -2.54% operator/cmd/manager/main.go
10
88.64
 operator/api/nodewright/v1alpha1/deployment_policy_webhook.go
10
53.74
 -0.88% operator/internal/controller/webhook_controller.go
9
45.65
 -44.85% operator/api/v1alpha1/deployment_policy_types.go
8
60.34
 -0.72% operator/cmd/cli/app/deploymentpolicy/deploymentpolicy_reset.go
5
87.15
 2.03% operator/api/v1alpha1/skyhook_webhook.go
5
76.28
 -0.84% operator/cmd/cli/app/lifecycle.go
4
86.15
 -2.56% operator/cmd/cli/app/node/node_ignore.go
4
80.13
 -1.16% operator/cmd/cli/app/package/package_status.go
4
89.74
 operator/internal/controller/migration_hold.go
3
87.69
 -1.45% operator/cmd/cli/app/node/node_list.go
3
85.63
 -1.12% operator/cmd/cli/app/node/node_reset.go
3
79.43
 -0.44% operator/cmd/cli/app/reset.go
3
83.56
 -0.68% operator/cmd/cli/app/update_state.go
3
71.55
 4.22% operator/internal/cli/utils/utils.go
3
96.0
 operator/internal/wrapper/zz.migration.0.18.0.go
2
94.9
 6.26% operator/api/v1alpha1/deployment_policy_webhook.go
2
90.31
 -0.89% operator/cmd/cli/app/node/node_status.go
2
85.98
 -0.81% operator/cmd/cli/app/package/package_rerun.go
2
67.39
 0.0% operator/cmd/cli/app/version.go
2
95.12
 operator/internal/cli/preflight/preflight.go
2
84.35
 0.29% operator/internal/wrapper/node.go
1
80.29
 -0.87% operator/cmd/cli/app/package/package_logs.go

Coverage Regressions

Lines Coverage ∆ File
244
27.99
 -39.93% operator/api/v1alpha1/zz_generated.deepcopy.go
95
45.65
 -44.85% operator/api/v1alpha1/deployment_policy_types.go
86
66.67
 -24.48% operator/api/v1alpha1/skyhook_types.go
10
83.96
 -0.43% operator/internal/controller/skyhook_controller.go
2
80.29
 -0.87% operator/cmd/cli/app/package/package_logs.go
1
85.98
 -0.81% operator/cmd/cli/app/package/package_rerun.go
Jobs
ID Job ID Ran Files Coverage
1 29869375647.1 59
78.84
 GitHub Action Run
Source Files on build 29869375647