NVIDIA / nodewright / 29869375647

push

github

feat: rename the Skyhook API to NodeWright with a rollback-safe migration bridge (#349)

* feat(api): add nodewright.nvidia.com group + Skyhook->NodeWright migration base

Introduce the nodewright.nvidia.com/v1alpha1 API group (NodeWright,
DeploymentPolicy) as a fork of the legacy skyhook.nvidia.com types, plus the
operator-side migration scaffolding:

- typed field-by-field conversion (api/v1alpha1/nodewright_conversion.go) with
  exhaustive fidelity + reflection-based zero-value-guard tests
- new-group validating/mutating webhooks
- a level-triggered mirror controller importing legacy Skyhook/DeploymentPolicy
  objects into the new group (read-only on source, ownership-stamped, never
  deletes the target)
- deprecation warnings on legacy Skyhook/DeploymentPolicy writes
- migration guide (docs/nodewright-migration.md)

Shared base for the rename. Reconciler repoint, CLI, chart sync, and the
nodewright type generator (re-fork automation) follow as separate changes.

Signed-off-by: Brian Lockwood <lockwobr@gmail.com>

* fix(ci): satisfy golangci-lint and markdownlint

- use reflect.Pointer instead of the deprecated reflect.Ptr in the conversion
  zero-value guard (govet inline check)
- fix markdownlint in docs/nodewright-migration.md: merge adjacent blockquotes
  (MD028) and repoint the dead #timing anchor to the renamed prerequisite
  section (MD051)

Signed-off-by: Brian Lockwood <lockwobr@gmail.com>

* fix(config): install nodewright CRDs and grant nodewright RBAC

The mirror controller creates nodewright.nvidia.com objects, so the operator
needs the new-group CRDs installed and RBAC to write them. Add the two
nodewright CRDs to config/crd/kustomization.yaml and kubebuilder:rbac markers
on the mirror reconciler (regenerating config/rbac/role.yaml). Without this a
deployed operator's mirror is denied / hits a missing CRD.

Signed-off-by: Brian Lockwood <lockwobr@gmail.com>

* chore(api): generate nodewright group from legacy (kill copy drift)

Add sc... (continued)

2281 of 2797 new or added lines in 42 files covered. (81.55%)

10013 of 12701 relevant lines covered (78.84%)

7.97 hits per line