kubernetes-sigs / lws / 29870185793
58%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 27
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 57.578% (+1.4%) from 56.222%
29870185793

push

github

web-flow 
[feat] Add placement policy field and support to DisaggregatedSet (#916)

* Implement DisaggregatedSet placement policy

* Address review: require slice label in slice-0 spread and validate subgroup-exclusive-topology

- SetPlacementAffinities: for slice 0, require the slice label to exist in
  the slice-spread anti-affinity term so unlabeled legacy pods (semantically
  slice 0) don't repel the new slice-0 pod during upgrade.
- Webhook: validatePlacement now rejects the subgroup-exclusive-topology
  annotation as well, and the error names the annotation actually found.

* Address review: scope ExclusiveTopology cross-set term to labeled pods

NotIn matches pods that lack the key entirely, so the cross-set
anti-affinity term could repel unrelated pods that carry the slice label
without the set-name label. Require the set-name label to exist so the
term only matches DisaggregatedSet-managed pods.

* Add integration test for placement policy vs LWS exclusive placement

Registers the DisaggregatedSet webhook in the envtest suite and adds
API-server-level coverage for composing spec.placementPolicy with the
LWS exclusive-topology annotations: either mechanism alone is admitted,
combining them is rejected on both create and update.

Signed-off-by: Benjamin Braun <benjaminbraun@google.com>

* Wait for placement e2e pods to be fully deleted between specs

Signed-off-by: Benjamin Braun <benjaminbraun@google.com>

---------

Signed-off-by: Benjamin Braun <benjaminbraun@google.com>

2344 of 4071 relevant lines covered (57.58%)

46.41 hits per line

Coverage Regressions

Lines Coverage ∆ File
13
92.39
 2.23% pkg/controllers/disaggregatedset/lws_manager.go
10
89.39
 4.29% pkg/webhooks/disaggregatedset/disaggregatedset_webhook.go
Jobs
ID Job ID Ran Files Coverage
1 29870185793.1 27
57.58
 GitHub Action Run
Source Files on build 29870185793