dangernoodle-io / breadboard / 29864543078

96%

push

github

refactor: make component discovery depth-agnostic (#980)

- redefine component identity as the innermost directory containing a
  CMakeLists.txt (the leaf rule), replacing the old any-dir-at-depth-1
  scan on the components/ side, so components/<group>/<name>/ resolves
  to <name> at any nesting depth, never the group
- scope the leaf rule to components/ only: in-tree audit found only 2
  of ~150 platform/<plat>/<name>/ dirs carry their own CMakeLists.txt
  (the rest build as part of the owning component's CMakeLists via
  REQUIRES/PRIV_REQUIRES), so requiring one there would silently drop
  nearly every platform-side entry; platform/ stays an unchanged
  one-level scan, documented in the module docstring
- raise CollisionError for two distinct leaf dirs resolving to the same
  name within one root (not just across roots, the pre-existing check)
- rewrite owner_of_path from fixed-position parsing (components/<name>
  -> parts[1]) to longest-prefix matching against the index's actually
  discovered directories, so it stays correct under any nesting depth
  and attributes a nested file to its leaf component, never the group
- guard the recursive components/ walk against a symlinked directory
  cycle (a risk surface the old single-level iterdir() could not hit),
  ancestor-scoped (current recursion path, immutable per branch) rather
  than a global visited set, so a non-cyclic symlink diamond (two
  aliases of the same real dir) still raises CollisionError instead of
  being silently suppressed; covers a direct self-cycle, a two-hop
  mutual cycle, and the diamond non-cycle case
- fix 3 fence test suites' synthetic fixtures (test_fence_clamp.py,
  test_fence_sat_sub.py, test_fence_callback_slot.py) to also write a
  CMakeLists.txt alongside each synthetic components/<name>/... source,
  matching the leaf rule's requirement (every real component dir has
  one); the zero-nesting-depth gap fixture used to test owner_of_path's
  fallback path is left untouch... (continued)

7440 of 8036 branches covered (92.58%)

Branch coverage included in aggregate %.

12601 of 12763 relevant lines covered (98.73%)

1212.93 hits per line