pantsbuild / pants / 29854433808
93%

DEFAULT BRANCH: main
Ran
Jobs 11
Files 1777
Run time 4min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 93.078%. Remained the same
29854433808

push

github

web-flow 
enable "thin LTO" in new `dist` profile (#23527)

This is a followup and replacement for
https://github.com/pantsbuild/pants/pull/23179 following the review
feedback there. Instead of adding more optimizations to the `release`
profile it creates a new `dist` profile. The bikeshed naming logic for
the profile breakdown:
* `release`: This is the built in cargo name so we are stuck with it. We
use it by default and it does "some" optimization which is a good
balance for the (I think) most common case of someone working on Python
rules code.
* `dist`: Intended to have maximum optimization for release artifacts.
It is same name used by `ruff` and `uv`. I moved the `codegen-units`
here as requested before.
 * `debug`: Whatever cargo defaults to.

In various tests with hyperfine for the prior PR I saw like `1.05 ±
0.06`, or `1.02 ± 0.09`. So not going to write a blog post about it, but
we don't seem to hit any pathological corner cases and I'll take a few
percentage points for free.

Rough Summary Table:

| Cold Build                  | Wall Time | `libengine.so` |
|-----------------------------|-----------|----------------|
| Old release (cgu=1, no LTO) | 2m33s     | 189.9 MiB      |
| New release (cgu=16)        | 1m53s     | 247.1 MiB      |
| dist (thin LTO, cgu=1)      | 3m57s     | 173.8 MiB      |

References:
*
https://nnethercote.github.io/perf-book/build-configuration.html#link-time-optimization
 * https://doc.rust-lang.org/cargo/reference/profiles.html#lto
 
NOTICE: Futzing with bash done my an LLM.

closes #23179

95254 of 102338 relevant lines covered (93.08%)

3.68 hits per line

Jobs
ID Job ID Ran Files Coverage
1 test_python_linux_x86_64_8/10 - 29854433808.1 1213
52.76
 GitHub Action Run
2 test_python_linux_x86_64_7/10 - 29854433808.2 1215
50.66
 GitHub Action Run
3 test_python_linux_x86_64_3/10 - 29854433808.3 1212
52.36
 GitHub Action Run
4 test_python_linux_x86_64_9/10 - 29854433808.4 1224
54.08
 GitHub Action Run
5 test_python_linux_x86_64_4/10 - 29854433808.5 1244
58.88
 GitHub Action Run
6 test_python_linux_x86_64_2/10 - 29854433808.6 1214
58.73
 GitHub Action Run
7 test_python_linux_x86_64_1/10 - 29854433808.7 1214
48.99
 GitHub Action Run
8 test_python_linux_x86_64_6/10 - 29854433808.8 1209
49.7
 GitHub Action Run
9 test_python_linux_arm64 - 29854433808.9 1193
51.66
 GitHub Action Run
10 test_python_linux_x86_64_5/10 - 29854433808.10 1230
60.3
 GitHub Action Run
11 test_python_linux_x86_64_0/10 - 29854433808.11 1234
57.19
 GitHub Action Run
Source Files on build 29854433808