Freegle / Iznik / 28012

73%

Build Type

push

circleci

Committed by edwh

Commit Message

feat(modtools): tell a moderator when someone else is holding the item

#1132 made the server enforce holds on memberships, admins, spam reports,
community events and volunteering, but the refusal surfaced as a generic
failure - the action correctly did not happen and nothing said why. Posts and
chat got this messaging in #1131; this brings the other five up to the same
standard.

Shared rather than repeated five times:
- api/heldConflict.js gains asHeldByOtherError() (a 409 carrying heldby becomes
  a tagged error naming the holder) and runHoldAware(), which also runs the
  caller's refresh so the "Held by X" state reaches the screen - the mod's copy
  is stale by definition when this fires.
- composables/useHeldNotice.js gives components { heldError, guardHold }: wrap
  the action, render heldError. Anything that is not a hold refusal still
  throws, so real faults are unaffected.

Wired through the five stores and their components, guarding at the entry
points (the SpinButton handle and modal confirms) rather than each call site,
so nothing downstream can miss it. ModVolunteerOpportunity only drops the item
from the list when the save actually happened - a refused approve has to stay
on screen with the reason showing.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UdLP1MADbXW9vPAh4JSWNM

Coverage Stats

13250 of 17447 branches covered (75.94%)

Branch coverage included in aggregate %.

103 of 161 new or added lines in 11 files covered. (63.98%)

243 existing lines in 10 files now uncovered.

139289 of 192908 relevant lines covered (72.2%)

37.99 hits per line