christophevg / yoker / 29831905386

87%

push

github

fix: add Windows platform gate and env guardrail case-insensitivity (PR #48)

Adds a Windows platform gate to the make tool: on sys.platform == "win32"
it returns a ToolResult error instead of attempting os.setsid/os.killpg,
which require POSIX process-group support. This fixes the CI failure on
windows-latest where os.killpg raised AttributeError.

Extends the env guardrail with a Windows-specific denylist
(_WIN_DENIED_EXTRA, 17 Windows-only env vars) and switches matching to
case-insensitive on Windows, where env var names are case-insensitive.
POSIX keeps case-sensitive matching and its existing denylist unchanged.

Tests:
- module-level pytestmark skipif(win32) on test_make.py so the POSIX-
  only behaviour tests do not run on Windows CI.
- new test_make_windows.py with a Windows-only platform-gate test
  asserting the ToolResult error path.
- test_env_guardrail.py gains Windows case-sensitivity tests and POSIX
  regression tests guarding the existing case-sensitive behaviour.

README gets a one-line platform-support note.

🤖 Implemented together with a coding agent.

1132 of 1295 branches covered (87.41%)

Branch coverage included in aggregate %.

6659 of 7906 relevant lines covered (84.23%)

0.84 hits per line