elixir-mint / mint / b63eaaa55e4a8cc07110c432d8807674a87e2222

88%

push

github

Don't leak target options into the proxy connection in forward-proxy mode (#494)

Mint.HTTP.connect/4 merged the target connect options with the proxy
options and handed the whole set to the connection to the proxy. A
target :hostname was therefore used as the proxy connection's hostname,
so with an :https proxy the proxy's certificate was verified against
the target's identity, and :transport_opts meant for the target applied
to the proxy socket.

Forward-proxy mode now keeps the two option sets separate, like tunnel
mode already does: the proxy connection is configured by the options in
the :proxy tuple, while the options given to Mint.HTTP.connect/4
describe the target (its :hostname identity and the :proxy_headers).

6 of 6 new or added lines in 2 files covered. (100.0%)

1443 of 1641 relevant lines covered (87.93%)

494.19 hits per line