29819875454
91%
main: 92%

Ran 21 Jul 2026 09:54AM UTC

Jobs 3

Files 127

Run time 1min

Badge

Embed ▾

Committed 21 Jul 2026 09:50AM UTC coverage: 91.485% (+0.1%) from 91.343%

Build # 29819875454

Build Type

push

github

Committed by

liran-funaro

Commit Message

[skills] Add development skill for writing new Go code

- New feature
- Documentation update

- Add a `development` skill capturing this repo's conventions for writing new Go
  code: code ordering (caller-before-callee, struct grouping, inline single-use
  helpers), concurrency (`errgroup` + `utils/channel` wrappers), Go 1.26 idioms,
  error handling, and logging — plus a `references/service-construction.md`
  blueprint for services/config/metrics.
- Wire the skill set together: `pr-review` now reads the `development` and `tests`
  skills and flags deviations as findings; `tests` gains a "Reusing Test Fixtures &
  Helpers" section (repo harnesses + `fabric-x-common` `testcrypto`/`tlsgen`).
- Fix stale references in `AGENTS.md` and `guidelines.md`: `logger.ErrorStackTrace(err)`
  does not exist — the real idiom is `logger.Errorf("%+v", err)`; also correct the
  `gprcerror` -> `grpcerror` typo in `guidelines.md`.
- Trim `AGENTS.md`'s now-duplicated convention prose to a summary that points at the
  `development` skill as the source of truth.

Validated with a with-skill vs. baseline comparison across 6 coding tasks; the skill
improved adherence on the subtle conventions a capable baseline still missed
(context-aware `channel.NewReader/Writer`, `%+v` boundary logging).

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

Coverage Stats

10314 of 11274 relevant lines covered (91.48%)

35101.68 hits per line

Coverage Regressions

Lines	Coverage	∆	File
2	88.94	0.0%	service/coordinator/validator_committer_manager.go
1	97.5	2.5%	mock/coordinator.go
1	86.42	-1.23%	loadgen/adapters/verifier.go
1	96.63	-1.12%	mock/sigverifier.go
1	94.95	-1.01%	loadgen/adapters/common.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	core-db-test - 29819875454.1	21 Jul 2026 09:54AM UTC	98	46.08	GitHub Action Run
2	db-test - 29819875454.2	21 Jul 2026 09:56AM UTC	127	79.74	GitHub Action Run
3	unit-test - 29819875454.3	21 Jul 2026 09:56AM UTC	91	85.1	GitHub Action Run

liran-funaro / fabric-x-committer / 29819875454
91%
main: 92%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 29819875454

liran-funaro / fabric-x-committer / 29819875454 91% main: 92%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 29819875454

liran-funaro / fabric-x-committer / 29819875454
91%
main: 92%

README BADGES
x