microlinkhq / browserless / 29778167541

79%

push

github

fix(errors): treat detached-frame and early-main-frame as retryable (#846)

`captureWithNavigationRetry` (wrapping page.pdf/screenshot) and `waitForReady`
only wait-and-retry when `isContextDestroyed` matches. Two frame-lifecycle
races on production 3.42.8 slipped through and failed the capture outright:

  Execution context is not available in detached frame or worker "<url>"   (6/24h)
  Requesting main frame too early!                                          (2/24h)

The first is Chrome's other phrasing of a frame detaching mid-operation — the
same condition as the already-matched "Attempted to use detached Frame", seen
on SPAs (app.oviond.com) that client-navigate to a sub-route while a print
targeting the old frame is in flight. The second is the inverse: an operation
ran before the page's main frame attached.

Both resolve once navigation settles, which is exactly what the retry does; a
page that never navigates falls through when the bounded retry budget
(timeouts.action) ends, same as today, just after a short wait.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

693 of 852 branches covered (81.34%)

Branch coverage included in aggregate %.

12 of 12 new or added lines in 1 file covered. (100.0%)

3683 of 4576 relevant lines covered (80.49%)

109499.65 hits per line