kobotoolbox / kpi / 29766524809

81%

master: 76%

Build Type

push

github

Committed by web-flow

Commit Message

feat(tags)!: remove tag detail endpoint DEV-2464 DEV-2463 (#7280)

### 📣 Summary

Remove `/api/v2/tags/<tag uid>` detail endpoint from the API.

### 📖 Description

Remove `/api/v2/tags/<tag uid>` detail endpoint from the API. All
information that was available there can be obtained either from the
list endpoint, `/api/v2/tags`, or by querying the asset endpoint, e.g.
`/api/v2/assets/?q=tags__name:<tag name>`. Note that `tags` is plural in
`tags__name`.

### 👷 Description for instance maintainers

The tags detail API was unused by the application and likely unused by
external parties given that it was broken in most cases: whenever a tag
was associated with multiple assets accessible to the current user, a
500 error was returned due to missing `distinct()` on the queryset after
permission joins.

The detail view also provided an `assets` array that started leaking the
URLs of all assets on the server after #5994 was merged.

### 👀 Preview steps

The detail endpoint `/api/v2/tags/<tag uid>` should exist before the
changes in this PR and should not exist after them.

---------

Co-authored-by: Guillermo <lgar89@gmail.com>

Coverage Stats

9309 of 12655 branches covered (73.56%)

11 of 12 new or added lines in 3 files covered. (91.67%)

26 existing lines in 3 files now uncovered.

30326 of 37218 relevant lines covered (81.48%)

5.51 hits per line