dangernoodle-io / breadboard / 29764910286

96%

push

github

feat(bb_sensors): cut /api/sensors over to per-section bb_data dispatch (B1-828 PR-2) (#962)

FULL BREAK of the old bb_response-backed composite GET/PATCH /api/sensors
endpoint -- zero live consumers workspace-wide, so no back-compat shim,
dual shape, or deprecation period. Governing design authority is
bb_http_section.h (REGISTRY-AGNOSTIC BY DESIGN; bb_diag_section is the
precedent to mirror).

- components/bb_sensors: new bb_sensors_wire.{c,h} (bb_data descriptors +
  gather/apply hooks for fan/power/thermal) and bb_sensors_dispatch.{c,h}
  (bind fan/power/thermal into bb_data, register the shared
  "/api/sensors/" bb_http_section namespace over them via the PR-1 helper).
  bb_sensors_init() is now a thin ESP-IDF glue that binds + calls
  bb_http_section_init(server) -- no route-handling logic of its own.
- fan is now a CONFIG resource (autofan cfg, or manual duty_pct when
  autofan isn't compiled in) served at GET/PATCH /api/sensors/fan -- NOT
  fan telemetry (rpm/die_c/board_c are no longer served here). power/
  thermal are read-only telemetry at GET /api/sensors/{power,thermal};
  PATCH on either maps to 405 (apply-less bb_data binding).
- deleted the now-dead bb_fan_emit_section()/bb_power_emit_section()/
  bb_thermal_emit_section() JSON-emit wrappers (their only caller was the
  old composite endpoint) and bb_response_dispatch_patch() + its tests
  (bb_sensors was bb_response's only PATCH consumer; bb_response itself
  stays -- bb_health still uses its GET-only path, per Fork C, deferred to
  a follow-up PR-3)
- bb_sensors no longer owns a bespoke section-registration API
  (bb_sensors_register_section is gone): the render/apply adapters are
  generic over bb_data, so any consumer that binds its own key is served
  automatically at /api/sensors/<key> -- BUT see the fixed-set note below,
  which bounds this to exactly {fan, power, thermal}.
- test/test_host/test_bb_sensors.c rewritten around the new pipeline
  (unit-level gather/apply + end-to-... (continued)

7511 of 8122 branches covered (92.48%)

Branch coverage included in aggregate %.

91 of 91 new or added lines in 2 files covered. (100.0%)

12734 of 12905 relevant lines covered (98.67%)

1191.37 hits per line