rero / rero-ils / 29720490614

91%

Build Type

push

github

Committed by rerowep

Commit Message

fix(acquisition): round monetary float arithmetic to 2 decimal places

Float multiplication such as 1.1 * 3 = 3.3000000000000003 in Python
caused the rollover to fail with a ValidationError when the computed
total_amount exceeded the account's allocated_amount by a rounding
artefact.

* round(amount * quantity, 2) in AcqOrderLine._build_total_amount
* round(amount * quantity - discount, 2) in _check_balance extension
* round(unreceived_quantity * amount, 2) in order line listener
* round(self_amount + children_amount, 2) for encumbrance and
  expenditure totals in account listener
* round(allocated_amount * rate / 100, 2) in AcqAccount.get_exceedance
* add test_build_total_amount verifying 0.1 * 3 rounds to 0.30
* add test_get_exceedance verifying 7% of 1000.10 rounds to 70.01
* add test_rollover_float_precision reproducing the exact rollover
  failure: account allocated_amount=3.3, order line amount=1.1 qty=3
* Closes #3998

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

Coverage Stats

4 of 4 new or added lines in 4 files covered. (100.0%)

24 existing lines in 1 file now uncovered.

24261 of 26572 relevant lines covered (91.3%)

0.91 hits per line