FlexMeasures / flexmeasures / 29721054646

83%

push

github

refactor: derive the UI flex-model schema from the DB schema (#2330)

* refactor: derive the UI flex-model schema from the DB schema

Make DBStorageFlexModelSchema the single source of truth for which
flex-model fields the UI editor exposes. UI_FLEX_MODEL_SCHEMA is now built
by iterating the DB schema's fields against a per-field UI-presentation
registry; a DB field without a presentation entry raises at import time,
so adding a flex-model field can no longer silently break DB/UI parity.

The rendered UI_FLEX_MODEL_SCHEMA is identical (key-for-key, value-for-value)
to the previous hand-maintained dict, verified by a committed baseline
fixture and a guardrail test. The parity test is repurposed to assert each
derived entry is well-formed. OpenAPI spec is unchanged.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016MLCUiSdXDqDBmg8GbYp1B
Signed-off-by: F.N. Claessen <claessen@seita.nl>

* Address review: drop the baseline guardrail and the changelog entry

The baseline-equivalence test and its JSON fixture proved the derived UI
schema matches the old one; that's done, so remove them (the well-formedness
test remains). Drop the changelog entry too - this is an internal refactor.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016MLCUiSdXDqDBmg8GbYp1B
Signed-off-by: F.N. Claessen <claessen@seita.nl>

---------

Signed-off-by: F.N. Claessen <claessen@seita.nl>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

13 of 16 new or added lines in 1 file covered. (81.25%)

15314 of 18653 relevant lines covered (82.1%)

0.82 hits per line