dangernoodle-io / breadboard / 29716199895

96%

push

github

refactor: migrate ota_check ingress off bb_json onto bb_data_apply (B1-859) (#957)

- POST /api/update/config now drives an "ota_check_config" bb_data
  binding (BB_DATA_APPLY_PATCH) instead of hand-rolled bb_json parsing.
  This site does NOT fit the factory-reset/wifi template unmodified: the
  single field is a JSON bool, and bb_serialize_populate() leaves an
  absent field's destination bytes untouched rather than clearing them,
  so a plain BB_DATA_APPLY_POST zero-seed cannot distinguish an omitted
  "enabled" from an explicit false. PATCH mode's gather()-seeded
  sentinel (a uint8_t value BB_TYPE_BOOL populate can never itself
  produce) restores the old reject-on-missing semantics.
- bb_ota_check_config_bind() (portable, no server dependency) wires the
  binding; called from bb_ota_check_register_init() in production and
  directly by host tests after bb_data_test_reset().
- add sentinel-focused tests driving bb_data_apply() directly against the
  bound key to assert the missing-field-still-rejects and
  present-field-overwrites-sentinel-and-persists behaviors, alongside the
  existing HTTP-handler-level rejection-path coverage (reused unchanged).

7436 of 8054 branches covered (92.33%)

Branch coverage included in aggregate %.

21 of 21 new or added lines in 1 file covered. (100.0%)

12620 of 12794 relevant lines covered (98.64%)

1191.29 hits per line