iotaledger / iota / 29711150958
69%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 1126
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 68.822% (+0.006%) from 68.816%
29711150958

push

github

web-flow 
feat(starfish-config): reduce default soft_leader_timeout to 5 ms (#12298)

# Description of change

Reduce the default StarfishSpeed `soft_leader_timeout` from 100 ms to 5
ms. Local operational parameter only — no protocol version change;
per-authority inconsistency is tolerated by design.

Rationale, from a 10-run sweep of the timer (0-100 ms) on a 20-validator
network with the geodistributed latency matrix (#12280):

- Commit latency and commits/s are insensitive to the timer across the
whole range (tx commit p50 254-263 ms, p95 740-745 ms, ~2000 commits/s
everywhere).
- Smaller values let high-latency validators propose without waiting on
strong-vote propagation: at the low end their own-block production
reaches full parity with the rest of the committee (16.2 blocks/s across
all 20 validators at 0 ms), and their leader votes leave earlier — which
is what reputation scoring rewards, since a vote only earns credit while
other validators still strong-link it.
- Proposing on soft timeout never skips the leader link
(`Core::try_new_block` requires the parent-round leader header for
non-forced proposals), so no votes are forfeited by proposing earlier.
- 5 ms rather than 0: the strong-vote readiness check stays armed for
votes arriving together with the parent-round quorum, instead of being
bypassed the instant a round opens. Behaviorally near-identical on
geodistributed topologies (SoftTimeout proposal share 16.3% vs 16.9%).

Full sweep data and discussion: #12280.

## Links to any relevant issues

#12280

## How the change has been tested

- [x] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [x] Patch-specific tests (correctness, functionality coverage)
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have checked that new and existing unit tests pass locally with
my changes

`starfish-config` (12) and `starfish-core --lib` (336) tests pass with
the new default. The 5 ms value itself w... (continued)

167195 of 242937 relevant lines covered (68.82%)

476820.75 hits per line

Coverage Regressions

Lines Coverage ∆ File
14
89.69
 -3.78% crates/iota-core/src/connection_monitor.rs
9
89.76
 -0.94% crates/iota-network/src/state_sync/mod.rs
4
89.3
 -0.46% crates/iota-core/src/grpc_indexes.rs
4
74.6
 -0.58% crates/iota-network/src/randomness/mod.rs
2
91.0
 -0.04% crates/iota-core/src/authority/authority_per_epoch_store.rs
2
83.23
 0.42% crates/iota-core/src/authority.rs
2
72.43
 -0.35% crates/iota-core/src/authority_server/validator.rs
2
91.46
 -0.09% crates/starfish/core/src/header_synchronizer.rs
1
86.11
 -2.78% crates/iota-cluster-test/src/test_case/native_transfer_test.rs
1
98.62
 -0.28% crates/iota-core/src/signature_verifier.rs
1
94.28
 0.44% crates/starfish/core/src/authority_service.rs
1
98.07
 -0.1% crates/starfish/core/src/cordial_knowledge.rs
1
73.65
 -0.1% crates/test-cluster/src/lib.rs
Jobs
ID Job ID Ran Files Coverage
1 nextest+simtest - 29711150958.1 1126
68.82
 GitHub Action Run
Source Files on build 29711150958