29686691341
91%
main: 91%

Ran 19 Jul 2026 12:22PM UTC

Jobs 3

Files 129

Run time 1min

Badge

Embed ▾

Committed 19 Jul 2026 12:16PM UTC coverage: 91.428% (-0.3%) from 91.727%

Build # 29686691341

Build Type

Pull #677

github

Committed by

liran-funaro

Commit Message

[test] fix flaky TestSignatureVerifierManagerPolicyUpdateAndRecover

Batch submission ran inside require.Eventually/require.Never conditions.
testify runs the condition in its own goroutine and, once waitFor
elapses, returns without waiting for it. submitTxBatch blocks on a full
input channel, so a condition that submitted leaked a goroutine past the
assertion that then (1) submitted stray batches into a later phase of the
test and (2) raced on the reassigned verifierStreams variable (an
observed data race). The stray flooding also kept signVerifier[0] parked
on a channel write, so a stopped server went undetected within the 30s
window and the connection metric stayed Connected.

Submit batches from a dedicated background goroutine that is started
before, and stopped after, each require.Eventually/require.Never, and
keep the conditions side-effect-free (pure reads of atomics and stable
locals). t.Cleanup tears the submitter down even if the test fails first.

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

Pull Request Pull Request #677: [test] fix flaky TestSignatureVerifierManagerPolicyUpdateAndRecover

Coverage Stats

10421 of 11398 relevant lines covered (91.43%)

42591.67 hits per line

Coverage Regressions

Lines	Coverage	∆	File
10	78.29	-1.94%	service/sidecar/sidecar.go
6	91.98	-2.83%	service/coordinator/signature_verifier_manager.go
4	79.82	-3.67%	service/vc/validator.go
3	95.69	-2.59%	mock/vcservice.go
3	91.27	-1.31%	service/vc/validator_committer_service.go
2	85.25	-0.82%	service/sidecar/relay.go
2	88.11	-0.88%	service/coordinator/validator_committer_manager.go
2	93.55	-3.23%	loadgen/adapters/loadgen.go
2	95.65	-2.17%	service/verifier/verifier_server.go
2	94.67	-0.82%	service/coordinator/coordinator.go
2	85.25	-0.55%	service/vc/database.go
1	97.5	2.5%	mock/coordinator.go
1	80.33	-1.64%	utils/utils.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	db-test - 29686691341.1	19 Jul 2026 12:22PM UTC	129	79.5	GitHub Action Run
2	unit-test - 29686691341.2	19 Jul 2026 12:22PM UTC	93	83.55	GitHub Action Run
3	core-db-test - 29686691341.3	19 Jul 2026 12:22PM UTC	100	45.19	GitHub Action Run

hyperledger / fabric-x-committer / 29686691341
91%
main: 91%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 29686691341

hyperledger / fabric-x-committer / 29686691341 91% main: 91%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 29686691341

hyperledger / fabric-x-committer / 29686691341
91%
main: 91%

README BADGES
x