omry / omegaconf / ef85118a-593c-433c-a9ca-1181aa1a0bbc

100%

master: 100%

push

circleci

Preserve ValueNode types in OmegaConf.masked_copy (#813) (#1308)

* Preserve ValueNode types in OmegaConf.masked_copy (#813)

`masked_copy` was built on top of `items_ex(resolve=False)`, which
unwraps top-level `ValueNode` leaves to their raw Python value. Those
values then re-enter `DictConfig.__init__` as plain Python objects and
get re-wrapped as `AnyNode`, dropping any `IntegerNode` / `StringNode` /
`EnumNode` typing that the source schema declared.

(Nested `DictConfig`/`ListConfig` survived because `items_ex` did not
unwrap container nodes — only leaf `ValueNode` instances.)

Switch to deep-copying the underlying nodes directly so the leaf node
class survives the copy, matching the type information at every level
of the source. Adds a regression test covering top-level `IntegerNode`
and `StringNode` and re-asserts nested typing.

* Use OmegaConf.structured() to satisfy pyrefly overload check

* Address review feedback for masked_copy

---------

Co-authored-by: Omry Yadan <omry@yadan.net>

1 of 1 new or added line in 1 file covered. (100.0%)

4138 of 4138 relevant lines covered (100.0%)

1.0 hits per line