AAEmu / AAEmu / 29675539646

5%

Build Type

push

github

Committed by web-flow

Commit Message

fix(game): Labor consumption for wild planting (#1463)

* feat(game): Added loading of skill category

- Added loading of the skill category field as well as added an enum for it.
- Added some comments

* fix(game): Removed duplicate packets in AddVisibleObject

* refactor(game): Simplified CSCreateDoodadPacket

* wip(game): sub-zone loading issue

* fix(game): Public-Farm detection

- Sub-Zones did not load correctly anymore. This has been fixed and Public-Farm areas are now once again detected correctly.
- Fixed some inconsistent naming of fields for ZoneId vs ZoneKey
- Replaced most functions inside `Point` with a ``Vector3` version in an attempt to further remove the old class.

* feat(game): Labor cost planting outside owned land

`CSCreateDoodadPacket` now verifies several conditions.
- Checks if the referenced item actually exists first.
- Finds the related skill to calculate the labor costs for placing this item.
- If in a public farm area, validates the type, and reduces cost to 0.
- If on player owned land, verify permission and set labor cost to 0.
- Verify required labor before placing.

* Suggestions by greptile and test fix

Added greptile's suggested fix for housing zones as this was also wrong.
Implemented missing interface item for tests (somebody else can probably fix this better)

---------

Co-authored-by: nl0bp <38990417+NL0bP@users.noreply.github.com>

Coverage Stats

4 of 105 new or added lines in 13 files covered. (3.81%)

3 existing lines in 2 files now uncovered.

3294 of 69314 relevant lines covered (4.75%)

0.05 hits per line