Freegle / Iznik / 27811

74%

push

circleci

fix(session): confirming an email lifts the bounce suspension

A member who bounced and then fixed their address stayed silently cut off from
mail. users.bouncing gates UnifiedDigestService (->where('bouncing', 0)),
UserManagementService and NotificationChaseUpService, but NOTHING resets it: the
only unbounce path is the manual, per-domain UnbounceDomainCommand, and the
email-verify handler never touched the flag. So the suspension was effectively
permanent even after the member proved the address works.

Confirming a validatekey is exactly that proof - they had to receive the
verification mail to click the link - so clear the suspension there. Clears both
halves the canonical unbounce does: the per-address bounce stamp
(users_emails.bounced, which gates welcome mail via whereNull('bounced')) and the
per-user users.bouncing flag.

Found while checking whether a member's address was bouncing. It wasn't, but 47
members were suppressed despite having validated AFTER their bounce - several
within minutes of it:

    bounced 13:15:12 -> validated 13:17:43
    bounced 09:33:12 -> validated 09:38:08

Those 47 have been cleared in prod; this stops them re-accumulating (~47/month
at the observed rate). Safe if an address later fails again: BounceService
re-suspends on the next bounce.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

13215 of 17412 branches covered (75.9%)

Branch coverage included in aggregate %.

15 of 15 new or added lines in 1 file covered. (100.0%)

138234 of 191672 relevant lines covered (72.12%)

37.97 hits per line