elixir-mint / mint / 57b1295385b7f067395ac7c9335df4f57e8e02c6

88%

push

github

Send origin Host header for plain-HTTP proxied requests (#491)

* Send origin Host header for plain-HTTP proxied requests

When connecting to an origin through a plain-HTTP (non-tunnel) proxy,
Mint.UnsafeProxy rewrote the request target to the absolute origin URI
but left the Host header unset, so Mint.HTTP1 defaulted it to the proxy's
own host:port. Per RFC 7230 section 5.4 the Host header must identify the
origin server; hackney and HTTPoison already do this.

Set the Host header to the origin (dropping the port when it is the
scheme default) in Mint.UnsafeProxy.request/5 before delegating to
Mint.HTTP1, whose put_new leaves it intact. A caller-supplied Host header
is still respected.

Fixes #446.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NX8ygWTRa86kE8k8Yn9bpu

* Apply suggestion from @ericmj

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Eric Meadows-Jönsson <eric.meadows.jonsson@gmail.com>

6 of 6 new or added lines in 1 file covered. (100.0%)

1434 of 1638 relevant lines covered (87.55%)

492.06 hits per line