orneryd / NornicDB / 29652676728

89%

main: 89%

Build Type

Pull #264

github

Committed by Allen Sanabria

Commit Message

fix(cypher): correctly evaluate relationship-existence predicates, resolve OPTIONAL MATCH rel vars, and guard non-detach DELETE

Three correctness fixes in the Cypher WHERE/DELETE mutation paths, the root
cause behind eshu-hq/eshu#5147.

1. Relationship-existence predicates in WHERE/COUNT/EXISTS were mis-evaluated
   for bracket-less and bracketed-undirected patterns. (n)--(), (n)-->(),
   (n)<--(), and (n)-[r]-() fell through the pattern gate to a default-true
   branch, so NOT (n)--() matched nothing and COUNT { (n)--() } = 0 matched
   every node. containsRelExistencePattern/bareRelDirection now classify these
   and route them to the existing relationship evaluator.

2. A relationship variable bound by an embedded OPTIONAL MATCH resolved to nil
   in the internal MATCH...RETURN probe that executeDelete/executeSet/
   executeRemove build, because parseTraversalPatternStateMachine locates the
   relationship bracket by scanning from the first node group's closing paren
   rather than searching for -[. executeMatch now routes an embedded
   OPTIONAL MATCH through executeCompoundMatchOptionalMatch. Also fixed a
   second, independent gap: executeRemove/applyRemoveToMatchedRows had no
   *storage.Edge support and duplicated rows when binding 2+ node variables.

3. A non-DETACH DELETE of a node that still has relationships silently
   cascade-deleted its edges. It now errors (openCypher/Neo4j semantics) unless
   the residual edges are themselves being deleted in the same statement.
   Behavior change documented in CHANGELOG.md.

Neo4j compatibility suite stays green; the previously masked
Delete_chunks_with_OPTIONAL_MATCH test is restored to a plain DELETE as the
green proof.

Pull Request Pull Request #264: fix(cypher): correctly evaluate relationship-existence predicates and guard non-detach DELETE

Coverage Stats

345 of 377 new or added lines in 7 files covered. (91.51%)

146613 of 164499 relevant lines covered (89.13%)

1.04 hits per line