stillwater-sc / universal / 29643883548

85%

master: 84%

Build Type

push

github

Committed by web-flow

Commit Message

fix(efloat): implement abs()/fabs() (were a no-op stub) (#1138)

The free function abs(efloat) returned its argument unchanged (`return a;`), so
abs(-x) == -x -- every caller that expected a magnitude got a signed value. Fix
clears the sign on a copy, which is correct for every state: a negative normal
becomes positive, -inf becomes +inf, -0 becomes +0, and NaN stays NaN. Also add
the standard <cmath> spelling fabs() as a thin alias.

Side benefit: log1p's small-argument guard `abs(x) < 0.375` (logarithm.hpp) was
effectively the signed test `x < 0.375` under the stub, routing moderately
negative arguments into the slow Taylor path; with a correct abs it now gates by
magnitude as intended (verified: log1p matches std::log1p to machine precision
for x in [-0.9, 0.9]).

New regression test elastic/efloat/math/absolute.cpp (target efloat_absolute)
covers normal/zero/inf/NaN and explicitly asserts abs(-x) != x. Validated on
gcc 13.3.0 and clang 18.1.3; existing efloat math suite unaffected.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Coverage Stats

5 of 5 new or added lines in 1 file covered. (100.0%)

42 existing lines in 6 files now uncovered.

49216 of 58166 relevant lines covered (84.61%)

6680475.28 hits per line