iotaledger / iota / 29625402493
69%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 1126
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 68.819% (+0.2%) from 68.669%
29625402493

push

github

web-flow 
feat(starfish-config): reduce default soft_leader_timeout to 5 ms (#12298)

# Description of change

Reduce the default StarfishSpeed `soft_leader_timeout` from 100 ms to 5
ms. Local operational parameter only — no protocol version change;
per-authority inconsistency is tolerated by design.

Rationale, from a 10-run sweep of the timer (0-100 ms) on a 20-validator
network with the geodistributed latency matrix (#12280):

- Commit latency and commits/s are insensitive to the timer across the
whole range (tx commit p50 254-263 ms, p95 740-745 ms, ~2000 commits/s
everywhere).
- Smaller values let high-latency validators propose without waiting on
strong-vote propagation: at the low end their own-block production
reaches full parity with the rest of the committee (16.2 blocks/s across
all 20 validators at 0 ms), and their leader votes leave earlier — which
is what reputation scoring rewards, since a vote only earns credit while
other validators still strong-link it.
- Proposing on soft timeout never skips the leader link
(`Core::try_new_block` requires the parent-round leader header for
non-forced proposals), so no votes are forfeited by proposing earlier.
- 5 ms rather than 0: the strong-vote readiness check stays armed for
votes arriving together with the parent-round quorum, instead of being
bypassed the instant a round opens. Behaviorally near-identical on
geodistributed topologies (SoftTimeout proposal share 16.3% vs 16.9%).

Full sweep data and discussion: #12280.

## Links to any relevant issues

#12280

## How the change has been tested

- [x] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [x] Patch-specific tests (correctness, functionality coverage)
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have checked that new and existing unit tests pass locally with
my changes

`starfish-config` (12) and `starfish-core --lib` (336) tests pass with
the new default. The 5 ms value itself w... (continued)

167188 of 242937 relevant lines covered (68.82%)

479071.4 hits per line

Coverage Regressions

Lines Coverage ∆ File
438
83.29
 0.53% crates/iota-core/src/authority.rs
297
69.52
 0.0% crates/iota/src/client_commands.rs
180
0.0
 0.0% crates/iota-open-rpc/src/examples.rs
152
63.09
 2.2% crates/iota-json-rpc-types/src/iota_transaction.rs
146
64.77
 1.54% crates/iota-grpc-server/src/merge.rs
144
1.7
 0.06% crates/iota-graphql-rpc/src/types/query.rs
112
83.3
 -0.03% crates/iota-types/src/transaction.rs
101
79.7
 0.68% crates/iota-types/src/crypto.rs
87
0.0
 0.0% crates/iota-indexer/src/apis/write_api.rs
81
70.37
 -0.1% crates/iota-core/src/authority/authority_store.rs
79
90.08
 -0.16% crates/iota-protocol-config/src/lib.rs
72
0.0
 0.0% crates/iota-core/src/generate_format.rs
56
38.97
 0.0% crates/iota/src/keytool.rs
45
0.0
 0.0% crates/iota-indexer/src/optimistic_indexing.rs
44
80.35
 0.4% crates/iota-core/src/authority_server/validator_v2.rs
42
78.21
 0.37% crates/iota-types/src/messages_consensus.rs
41
87.92
 -0.48% crates/iota-types/src/messages_checkpoint.rs
37
51.68
 -2.5% crates/iota-types/src/iota_sdk_types_conversions.rs
36
94.26
 0.1% crates/iota-core/src/consensus_adapter.rs
36
92.23
 0.34% crates/iota-core/src/consensus_handler.rs
33
88.68
 16.65% crates/iota-transaction-builder/src/utils.rs
29
93.69
 -0.01% iota-execution/latest/iota-adapter/src/programmable_transactions/execution.rs
23
90.44
 0.34% crates/iota-types/src/base_types.rs
21
73.75
 -0.29% crates/test-cluster/src/lib.rs
19
84.17
 -1.12% crates/iota-core/src/post_consensus_validation.rs
17
89.83
 -0.35% crates/iota-grpc-server/src/types.rs
15
86.48
 -2.5% crates/iota-test-transaction-builder/src/lib.rs
9
95.58
 0.0% crates/iota-json-rpc-types/src/iota_primitives.rs
9
81.44
 1.44% crates/iota-single-node-benchmark/src/mock_storage.rs
8
85.78
 -0.03% crates/iota-snapshot/src/writer.rs
7
92.08
 7.1% crates/iota-transaction-builder/src/lib.rs
7
91.18
 0.6% crates/iota-transaction-checks/src/deny.rs
6
57.48
 0.42% crates/iota-json-rpc-types/src/iota_object.rs
6
72.11
 -4.08% crates/iota-json-rpc-types/src/lib.rs
6
78.32
 -2.1% crates/iota-sdk/src/lib.rs
6
63.7
 3.56% crates/iota-types/src/in_memory_storage.rs
6
81.27
 0.0% crates/starfish/core/src/commit.rs
4
89.3
 -0.46% crates/iota-core/src/grpc_indexes.rs
4
74.89
 -0.29% crates/iota-network/src/randomness/mod.rs
4
91.46
 0.0% crates/iota/src/client_ptb/error.rs
4
56.52
 -2.17% crates/iota-stardust-types/src/block/output/foundry.rs
4
58.33
 -33.33% crates/iota-stardust-types/src/block/output/unlock_condition/timelock.rs
4
68.94
 -2.48% crates/iota-types/src/move_authenticator.rs
3
92.51
 -0.18% crates/iota-core/src/authority/consensus_quarantine.rs
3
80.61
 -0.18% crates/iota-core/src/checkpoints/mod.rs
3
88.36
 0.09% crates/iota-genesis-builder/src/lib.rs
3
46.9
 0.0% crates/iota-genesis-builder/src/stardust/types/snapshot.rs
3
82.14
 0.0% crates/iota-genesis-builder/src/validator_info.rs
3
0.0
 -6.38% crates/iota-stardust-types/src/block/protocol.rs
3
64.89
 -0.64% crates/iota-types/src/storage/shared_in_memory_store.rs
3
95.45
 -2.73% crates/starfish/config/src/committee.rs
3
84.21
 -3.16% crates/starfish/config/src/crypto.rs
3
87.88
 -0.45% crates/starfish/core/src/commit_syncer/regular.rs
2
85.5
 0.16% crates/iota-config/src/node.rs
2
91.0
 -0.04% crates/iota-core/src/authority/authority_per_epoch_store.rs
2
96.3
 -0.32% crates/iota-core/src/overload_monitor.rs
2
79.13
 -0.97% crates/iota-proc-macros/src/lib.rs
2
79.37
 -0.7% crates/iota-sdk/src/wallet_context.rs
2
98.85
 0.01% crates/iota-types/src/deny_list_v1.rs
2
85.9
 -0.38% crates/prometheus-filtered/src/lib.rs
1
86.11
 0.0% crates/iota-cluster-test/src/test_case/native_transfer_test.rs
1
90.0
 -4.74% crates/iota-core/src/post_consensus_tx_reorder.rs
1
98.62
 -0.28% crates/iota-core/src/signature_verifier.rs
1
99.47
 0.01% crates/iota-json-rpc/src/transaction_execution_api.rs
1
96.88
 56.4% crates/iota-types/src/signature.rs
1
89.51
 -0.11% crates/starfish/core/src/commit_syncer/fast.rs
1
98.07
 -0.1% crates/starfish/core/src/cordial_knowledge.rs
1
96.55
 0.18% crates/starfish/core/src/dag_state.rs
1
91.88
 0.37% crates/starfish/core/src/header_synchronizer.rs
Jobs
ID Job ID Ran Files Coverage
1 nextest+simtest - 29625402493.1 1126
68.82
 GitHub Action Run
Source Files on build 29625402493