stacklok / toolhive / 29597663350

69%

Build Type

push

github

Committed by web-flow

Commit Message

Strip hop-by-hop headers before SigV4 signing (#5836)

* Strip hop-by-hop headers before SigV4 signing

httputil.ReverseProxy removes hop-by-hop headers before forwarding.
If they remain on the request they can cause signature mismatches
(403 InvalidSignatureException) or trigger deletion of newly-signed
headers like X-Amz-Date and Authorization.

Strip them from the original request before creating the signing
clone, not just from the clone itself.

Signed-off-by: haoxiang Yan <108142374+Yanhaoxi@users.noreply.github.com>

* Fix lint in hop-by-hop SigV4 test helpers

The extraCheck closures take *testing.T, so revive/thelper require
t.Helper() as the first statement; the Authorization case also left
the signedHeaders parameter unused. Add t.Helper() to both and rename
the unused parameter to _.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Signed-off-by: haoxiang Yan <108142374+Yanhaoxi@users.noreply.github.com>
Co-authored-by: Jakub Hrozek <jakub@stacklok.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

Coverage Stats

11 of 11 new or added lines in 1 file covered. (100.0%)

6 existing lines in 3 files now uncovered.

75057 of 109422 relevant lines covered (68.59%)

72.96 hits per line