orneryd / NornicDB / 29590313685

89%

main: 89%

Build Type

Pull #263

github

Committed by Allen Sanabria

Commit Message

fix(cypher): fail loud on unsupported multi-clause query shapes

The string-slicing WITH interpreters (executeMatchWithClause /
executeMatchWithOptionalMatch / executeCompoundMatchOptionalMatch) silently
returned corrupt results for a set of multi-clause read shapes they cannot
evaluate: raw expression text as a column value ("DISTINCT a.name",
"length(path)", "min(length(path))"), a bool/nil where a value was expected,
skipped DISTINCT dedup, or dropped rows. Silent data corruption is the worst
failure mode for a graph DB.

Add unsupportedMultiClauseShape (pkg/cypher/failloud_guard.go), invoked at the
three multi-clause handler entry points, which detects these specific shapes and
returns a clear, actionable error mirroring the existing 'unsupported clause
after CALL {}' contract. Scoped to multi-clause reads only: single-clause
RETURN DISTINCT / min()/max(), working WITH+OPTIONAL/aggregate/collect
projections, and EXPLAIN/PROFILE queries are untouched.

Failing-then-green tests for all 7 symptom shapes (failloud_multiclause_test.go).
Full pkg/cypher suite passes with zero tests flipped. New-code coverage 97.8%
(helpers 100%). Benchmark +0.76% / +8 allocs on the guarded path (under the 5%
budget); guard runs only on cache-miss. -race clean.

Local validation only; not yet proposed upstream.

Pull Request Pull Request #263: fix(cypher): fail loud on unsupported multi-clause query shapes

Coverage Stats

174 of 177 new or added lines in 3 files covered. (98.31%)

146550 of 164424 relevant lines covered (89.13%)

1.04 hits per line