kobotoolbox / kpi / 29586939962

81%

master: 76%

push

github

fix(project-views): return asset_count for users list DEV-2438 (#7264)

### 📣 Summary

Fixes a server error when listing the users of a project view.

### 📖 Description

Opening the **Users** tab of a project view failed with a server error
and showed no one. The list now loads correctly again, including each
user's project count.

### 💭 Notes

- `UserListSerializer` is shared by `/api/v2/users/` and
`/api/v2/project-views/{uid}/users/`. A perf change (DEV-1236, #6447)
switched `get_asset_count` to read a `user.assets_count` attribute that
only `UserViewSet` precomputes per page — the project-views endpoint
never sets it, so the serializer raised `AttributeError: 'User' object
has no attribute 'assets_count'` → 500.
- Fix: `get_asset_count` falls back to a direct `user.assets.count()`
when the attribute isn't precomputed. Keeps the optimized path for
`/api/v2/users/`, restores the pre-#6447 behavior for project-views.
- Added a regression test for the previously-uncovered `users` action.

### 👀 Preview steps

1. ℹ️ be a superuser with a project view configured
(region/organization)
2. `GET /api/v2/project-views/{uid}/users/`
3. 🔴 [on main] the request returns `500` (`AttributeError: 'User' object
has no attribute 'assets_count'`)
4. 🟢 [on PR] the request returns `200` with the user list, each entry
carrying `asset_count`

9300 of 12652 branches covered (73.51%)

0 of 3 new or added lines in 1 file covered. (0.0%)

30297 of 37228 relevant lines covered (81.38%)

5.51 hits per line