microlinkhq / browserless / 29508814524

79%

push

github

fix(pdf): detect covered content in readiness gate, keep zero-screenshot fast path (#839)

* fix(pdf): verify probe screenshot before skipping blank-SPA poll

The #837 painted/text fast path trusted in-page DOM signals alone. A page
with 200+ chars of SSR text (or a decoded hero image) under a fixed white
loading overlay passed waitForReady and skipped the white-screen poll,
shipping a blank PDF.

Take one cheap probe capture when the gate reports painted content; only
skip the poll loop when that capture is non-white. Adds a regression test
for the overlay case.

* fix(screenshot): detect covered content in readiness gate, keep zero-screenshot fast path

A fixed opaque overlay (or white-on-white text) passes every DOM paint
signal while a capture stays white, so PR #837's fast path could ship a
blank PDF. PR #838 fixed it with a probe screenshot on every painted
page, which pays a capture on the fast path and makes the branch
equivalent to the poll loop's first iteration.

Instead, detect the cover in the in-page snapshot itself:

- `covered`: hit-test the counted content samples for an unrelated
  opaque viewport-filling layer, plus a root-level scan for
  `pointer-events: none` overlays hit-testing can't see
- skip text whose color matches its effective background (invisible on
  capture) when counting the `text` paint signal
- pdf fast path requires `!ready.covered`; the probe screenshot is
  removed, so a clean painted page takes zero captures again

Covered or suspicious pages fall through to the existing blank-SPA
screenshot poll, where a capture verifies ground truth.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

691 of 850 branches covered (81.29%)

Branch coverage included in aggregate %.

12 of 114 new or added lines in 1 file covered. (10.53%)

3676 of 4555 relevant lines covered (80.7%)

110004.29 hits per line