kubernetes-sigs / lws / 29508491920

58%

Build Type

push

github

Committed by web-flow

Commit Message

webhook: reject maxSurge=0 and maxUnavailable=0 in DisaggregatedSet (#912)

The LWS validating webhook already enforces that maxSurge=0 and
maxUnavailable=0 is rejected when replicas > 0. The DisaggregatedSet
validating webhook was missing the same check, so a DisaggregatedSet
with this combination was admitted; the controller then tried to create
a child LWS on every reconcile, which the LWS webhook rejected each
time, causing an infinite back-off loop with no user-visible error on
the DS object.

Changes:
- Added validateRoleMaxSurgeUnavailable() which mirrors the LWS webhook
  check. Uses intstr.GetScaledValueFromIntOrPercent so percentage values
  like '0%' are also caught.
- Roles with replicas=0 (or unset) are exempt, matching LWS behaviour.
- Added validatePositiveIntOrPercentDS and isNotMoreThan100PercentDS
  helpers for per-field validation.
- Added unit tests covering int literals, percentage strings, and the
  zero-replica exemption.

Fixes: https://github.com/kubernetes-sigs/lws/issues/869

Coverage Stats

41 of 55 new or added lines in 2 files covered. (74.55%)

1 existing line in 1 file now uncovered.

2223 of 3954 relevant lines covered (56.22%)

47.48 hits per line