stacklok / toolhive / 29504568541

68%

Build Type

push

github

Committed by web-flow

Commit Message

Add Bedrock compatibility flag to thv llm setup (#5832)

* Add Bedrock compatibility flag to thv llm setup

Configuring Claude Code against an LLM gateway that forwards to AWS
Bedrock previously required hand-editing settings.json: Bedrock rejects
Claude Code's experimental anthropic-beta headers, and Bedrock-style
model IDs must be pinned per tier. This adds a --bedrock-compat flag to
"thv llm setup" (and "thv llm config set") that writes
CLAUDE_CODE_DISABLE_EXPERIMENTAL_BETAS=1 and the three per-tier model IDs
into ~/.claude/settings.json.

The flag reuses the existing ClearWhenEmpty key-spec mechanism, so
teardown, revert, and idempotent re-runs work with no new writer. The
setting is persisted so a later plain "thv llm setup" keeps it. --models
overrides the default us.anthropic.* IDs (mapped to tiers by matching
haiku/opus/sonnet in the ID), and --enable-1m appends the [1m] suffix to
opus/sonnet to opt into the 1M context window on Bedrock.

Bedrock keys only attach to Claude Code; the flag is a no-op for other
clients and warns when Claude Code is not among the configured tools.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Address Bedrock review: dedupe flags, fix stale warning

Resolves the panel review on #5832:

- Single source of truth for --models: promote it from BedrockConfig to
  top-level Config.Models so the credential-helper path (Claude Desktop
  inferenceModels) and the Bedrock tier mapping read one persisted value.
  A plain re-run no longer drops the Claude Desktop model list.
- Warn (not silently ignore) --enable-1m without --bedrock-compat.
- Report duplicate-tier --models overrides instead of silently dropping
  the clobbered entry (last still wins).
- Guard against a doubled [1m] suffix when an override already carries it.
- Extract addLLMConnectionFlags and applyChangedLLMFlags helpers shared by
  "config set" and "setup".

Also fix a warning that fired on every setup once bedrock-compat was
persis... (continued)

Coverage Stats

135 of 158 new or added lines in 4 files covered. (85.44%)

89 existing lines in 6 files now uncovered.

73797 of 108402 relevant lines covered (68.08%)

64.6 hits per line