stacklok / toolhive / 29481413727

69%

push

github

Stop VirtualMCPServer hot-reconcile on cleared imagePullSecrets (#5821)

A stale imagePullRefsHashAnnotation left on a Deployment from a prior
reconcile (when imagePullSecrets was non-empty) survived every
MergeAnnotations call once the desired list became empty, since the
desired map no longer carried a key to overwrite it. That made
imagePullSecretsNeedsUpdate report drift on every reconcile, updating
the Deployment roughly twice every 30 seconds indefinitely.

Make imagePullSecretsNeedsUpdate a plain hash comparison, and prune
the annotation explicitly at the write site when it's no longer
wanted so the stale key actually gets removed instead of resurrected
by the merge.

Fixes #5817

7 of 7 new or added lines in 1 file covered. (100.0%)

73673 of 108267 relevant lines covered (68.05%)

63.99 hits per line