moonbitlang / core / 5177

91%

push

github

refactor: use nested with-patterns and flatten nested matches

Follow-up to the or-pattern `with` defaults adoption, exercising the
feature in nested pattern positions:

- sorted_map/sorted_set `height`: single-arm field extraction
  `Some({ height, .. }) | (None with height = 0) => height`
- sorted_map/sorted_set `height_ge`: both children's heights extracted
  with defaults in one tuple pattern, replacing a two-level nested
  match; relies on the AVL invariant that stored heights are >= 1
- argparse `option_conflict_label` / `global_option_conflict_label`:
  the triple-nested Option fallback chain flattens into ordered arms
  with nested patterns (no `with` needed)
Reviewed by Codex CLI (codex-cli 0.144.1): "No findings; approved.
height_ge is equivalent: private nodes start at height 1 and all
recalculation paths preserve height >= 1... Argparse retains
long-before-short priority."

Signed-off-by: Codex CLI <codex@openai.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

10 of 12 new or added lines in 6 files covered. (83.33%)

15710 of 17213 relevant lines covered (91.27%)

191052.06 hits per line