umputun / revdiff / 29467243034

90%

Build Type

push

github

Committed by web-flow

Commit Message

feat: signal-safe annotation save and tmux window mode (#262)

fixes the annotation-loss corner case from #262: a review running in a tmux `display-popup` loses all in-memory annotations when the SSH/tmux client dies (VPN drop), because the popup is torn down before revdiff can save. Two independent parts.

**binary safety net.** On a signal-delivered termination (SIGHUP from a disconnect, or SIGTERM) revdiff now saves the current annotations to the history file, never the `-o` output. This keeps `O` (the deliberate "ready for review" handoff) and `Q` (discard) meaning exactly what they did before, while making sure an abrupt disconnect no longer drops work. A `shutdownGuard` (`sync.Once` + `atomic.Bool`) owns SIGHUP/SIGTERM via `tea.WithoutSignalHandler()`; SIGINT is caught and drained so a Ctrl-C meant for an external `$EDITOR` no longer quits revdiff. Recovery stays the existing "load newest from `~/.config/revdiff/history/`" flow, and history writes now go through the atomic writer.

**first-class tmux window mode.** `REVDIFF_TMUX_WINDOW=1` opens the review in a server-owned tmux window instead of a client-owned `display-popup`, so a dropped SSH session survives exactly like your shell does, reattach and the live review is still there. It opens focused and restores the prior window on exit; agent-deck auto-detection is unchanged.

*note: SIGTERM no longer writes the `-o` output, it is a safety-net save now, not a handoff. Interactive typed Ctrl-C stays a no-op in the raw-mode TUI. The window mode is launcher-only and works with any binary; the signal safety net needs this binary.*

Related to #262

Coverage Stats

42 of 75 new or added lines in 3 files covered. (56.0%)

1 existing line in 1 file now uncovered.

10898 of 12112 relevant lines covered (89.98%)

2959.15 hits per line