MushroomObserver / mushroom-observer / 29459188413

99%

main: 99%

Pull #4814

github

Confirm image transfers in the same run, not a never-scheduled second pass

Image::Processor::Verifier#transfer_image checked all_synced? against the
remote snapshot taken BEFORE upload, so a first-time upload was never
confirmed on the run that made it -- by design it deferred confirmation to
"the next run's fresh remote check". But TransferImagesJob runs exactly
once per image and never re-enqueues, and nothing else polls for
transferred=false images, so that second run never came: every fresh
upload landed on the server but stayed transferred=false with its local
copies intact, until StaleImageFilesJob flagged it an hour later.

Re-read the servers after uploading (only when something was uploaded) and
check all_synced? against that fresh snapshot. A file just pushed is now
confirmed present by an independent `find` before its local copy is
deleted -- still not trusted on the uploader's own return value, so a
silently-failed upload is safely left unmarked.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

8 of 8 new or added lines in 1 file covered. (100.0%)

52694 of 53159 relevant lines covered (99.13%)

760.83 hits per line