dunglas / go-urlpattern / 29458502182

92%

main: 92%

Build Type

Pull #12

github

Committed by dunglas

Commit Message

perf: share precompiled regexps for common component patterns

Compiling a URLPattern compiles one regexp per URL component. In typical
patterns most components are the full wildcard (the default for username,
password, search and hash) or empty (a common port), whose generated
expressions are a small fixed set of constant strings. Reuse a shared
precompiled *regexp.Regexp for those (safe for concurrent use) instead of
calling regexp.Compile per component.

New geomean: -21% time, -25% B/op, -22% allocs (BenchmarkNew).

Pull Request Pull Request #12: perf: share precompiled regexps for common component patterns

Coverage Stats

4 of 6 new or added lines in 1 file covered. (66.67%)

2 existing lines in 1 file now uncovered.

1489 of 1620 relevant lines covered (91.91%)

1133.99 hits per line