dunglas / go-urlpattern / 24727388304

92%

push

github

refactor!: rename error vars to ErrFoo and expand lint enforcement (#11)

* refactor!: rename exported error vars from FooError to ErrFoo

BREAKING CHANGE: every exported error identifier changes name to match
the staticcheck ST1012 convention that the Go standard library uses.
Consumers referencing these variables must update their imports:

  NoBaseURLError             -> ErrNoBaseURL
  UnexpectedEmptyStringError -> ErrUnexpectedEmptyString
  NonEmptySuffixError        -> ErrNonEmptySuffix
  BadParserIndexError        -> ErrBadParserIndex
  DuplicatePartNameError     -> ErrDuplicatePartName
  RequiredTokenError         -> ErrRequiredToken
  InvalidIPv6HostnameError   -> ErrInvalidIPv6Hostname
  InvalidPortError           -> ErrInvalidPort
  EmptyPartNameError         -> ErrEmptyPartName
  InvalidModifierError       -> ErrInvalidModifier
  InvalidPrefixOrSuffix      -> ErrInvalidPrefixOrSuffix
  InvalidPartNameError       -> ErrInvalidPartName
  TypeError                  -> ErrType

Also drops the ST1012 exclusion from .golangci.yml since the codebase
now satisfies it.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* chore: address remaining golangci-lint findings and enforce them

Expand the enabled linter set in .golangci.yml (err113, goconst,
gocritic, intrange, modernize, perfsprint, thelper, unconvert, unparam,
wastedassign, whitespace) and address every new finding:

- wastedassign: collapse ExecInit's 8 dead var = "" initializations and
  one in parser.go where regexpValue was assigned and immediately
  reassigned.
- gocritic (assignOp / ifElseChain / typeSwitchVar): use x += y, rewrite
  if-else chains to switch, switch on typed values.
- intrange: for range b.N in benchmarks, for i := range len(portValue)
  in the port prefix check; keep escape.go as-is (i needed after loop)
  with a //nolint rationale.
- modernize: replace interface{} with any in tests, use slices.Contains.
- perfsprint: fmt.Sprintf("%d", i) -> strc... (continued)

64 of 71 new or added lines in 6 files covered. (90.14%)

1482 of 1613 relevant lines covered (91.88%)

1132.0 hits per line