MushroomObserver / mushroom-observer / 29446755694

99%

main: 99%

Build Type

Pull #4811

github

Committed by nimmolo

Commit Message

Address Copilot review on #4811: fix stale doc comment, memoize official-locale fallback lookup

- db_fallback.rb's class comment pointed at config/application.rb for
  the backend chain wiring; it actually lives in
  config/initializers/i18n_backend.rb.
- text_for queried Language.official on every fallback lookup for a
  locale lacking its own override -- the common case on a cold cache
  for any non-English locale. Memoized on the DbFallback instance
  itself (one per process) rather than on Language.official: adding
  the memoization to Language directly would hand every caller
  (including tests) the same cached AR instance across
  requests/tests, and a stale cached association surviving a
  rolled-back test transaction is exactly the kind of bug that risks
  -- confirmed by trying it first and watching
  LanguageExporterTest#test_import_official break from stale
  translation_strings association data leaking across tests.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Pull Request Pull Request #4811: Replace file-based I18n backend with Solid Cache + `DbFallback` (`#4807`)

Coverage Stats

65 of 65 new or added lines in 7 files covered. (100.0%)

3 existing lines in 2 files now uncovered.

52743 of 53210 relevant lines covered (99.12%)

843.01 hits per line